Open
Conversation
Contributor
Author
|
Ok. The 2nd commit deals with NaNs vs 0s issue. I'll save for later the proper documentation and testing. That's it for this PR. In others using other functions, I might have to do similar changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of the analyses where I needed to first write a function to then have groupby's map call it, as opposed to the other simpler cases. There is a bunch of others coming up. They will all look similar but I will make a PR for each to ease review.
The Definitions controls aren't pretty but I'll think about how to redesign it once all the controls are in there.
There is also the problem where the local plots draws 0s where there are no date (past 2014 for histo and pre 2014 for scenario). I had resolved that for the built-in groupby functions, but here I think I need to revisit my functions to see how they handle missing. I will do that now before submitting other wwc variables.